Assignment 3: Code Review and Test
Due: Tuesday the 3rd of March at 4:10 pm
Purpose
- Provide a code review (+1) on a pull request you did not author
- Provide proof of running other code provided from a pull request (+10)
- Improve and merge your assignment 2 pull request after addressing feedback
- Add a unit test to a new pull request
Partners
This is an individual assignment.
Assignment
Part 1
- Review the open pull requests with the assignment2 label.
- +1 - Find a PR for Assignment 2 - perform a code review and add your comments inline with the code (ideally one that isn't reviewed yet).
- +10 - Find another PR for Assignment 2 - checkout this branch locally, perform the instructions provided in the README, and attach proof of output as a code review comment.
- Additional requirements
- Be professional. Practice egoless programming. Golden rule.
- Include ideas for improvement.
- Fix issues suggested by reviewers (@ mention the user)
- Re-review after suggested fixes are complete (@ mention the user)
Part 2
- After merging your Pull Request after comments / reviews are complete, start a new branch labeled *yourname*-assignment3
- Add at least one unit test that asserts the program behaves as expected
- Update the README.md to include additional instructions on how to run these tests
Grading - 10 points
- 2 points - +1 code review(s) on a PR
- 2 points - +10 code output run(s) on a separate PR
- 1 points - fixing any issues and merging your PR from assignment 2
- 5 points - adding a unit test and updated README with a new branch and pull request